From b623c9540e3327aabe077d28a2357bd90c716eac Mon Sep 17 00:00:00 2001 From: Michael Radka Date: Thu, 2 Nov 2023 17:58:35 -0400 Subject: [PATCH 1/5] #816 Boolean-type Consistency Signed-off-by: Michael Radka --- dictionary.json | 28 +++++++++++++++++++++++----- objects/http_cookie.json | 6 ++++++ objects/kb_article.json | 2 +- 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/dictionary.json b/dictionary.json index ea21be07f..0a867e750 100644 --- a/dictionary.json +++ b/dictionary.json @@ -1541,6 +1541,10 @@ "type": "string_t" }, "http_only": { + "@deprecated": { + "message": "Use the is_http_only attribute instead.", + "since": "v1.1.0" + }, "caption": "HTTP Only", "description": "A cookie attribute to make it inaccessible via JavaScript", "type": "boolean_t" @@ -1729,6 +1733,11 @@ "description": "Indicates if a fix is available for the reported vulnerability.", "type": "boolean_t" }, + "is_http_only": { + "caption": "HTTP Only", + "description": "A cookie attribute to make it inaccessible via JavaScript", + "type": "boolean_t" + }, "is_managed": { "caption": "Managed Device", "description": "The event occurred on a managed device.", @@ -1764,6 +1773,16 @@ "description": "The indication of whether this is a lease/session renewal event.", "type": "boolean_t" }, + "is_secure": { + "caption": "Secure", + "description": "The cookie attribute to only send cookies to the server with an encrypted request over the HTTPS protocol.", + "type": "boolean_t" + }, + "is_superseded": { + "caption": "The patch is superseded.", + "description": "The vendor patch has been replaced by another.", + "type": "boolean_t" + }, "is_system": { "caption": "System", "description": "The indication of whether the object is part of the operating system.", @@ -2855,6 +2874,10 @@ "type": "integer_t" }, "secure": { + "@deprecated": { + "message": "Use the is_secure attribute instead.", + "since": "v1.1.0" + }, "caption": "Secure", "description": "The cookie attribute to only send cookies to the server with an encrypted request over the HTTPS protocol.", "type": "boolean_t" @@ -3179,11 +3202,6 @@ "description": "Additional data supporting a finding as provided by security tool", "type": "json_t" }, - "superseded": { - "caption": "The patch is superseded.", - "description": "The vendor patch has been replaced by another.", - "type": "boolean_t" - }, "surname": { "caption": "Surname", "description": "The last or family name for the user.", diff --git a/objects/http_cookie.json b/objects/http_cookie.json index f7a8690f8..8db19533a 100644 --- a/objects/http_cookie.json +++ b/objects/http_cookie.json @@ -14,6 +14,12 @@ "http_only": { "requirement": "optional" }, + "is_http_only": { + "requirement": "optional" + }, + "is_secure": { + "requirement": "optional" + }, "name": { "description": "The HTTP cookie name.", "requirement": "required" diff --git a/objects/kb_article.json b/objects/kb_article.json index 679752bf4..229a37582 100644 --- a/objects/kb_article.json +++ b/objects/kb_article.json @@ -28,7 +28,7 @@ "description": "The product details the kb article applies.", "requirement": "optional" }, - "superseded": { + "is_superseded": { "description": "The kb article has been replaced by another.", "requirement": "optional" }, From 9756192b0c23da4e71813aec3aca15e0c040ac2c Mon Sep 17 00:00:00 2001 From: Michael Radka Date: Mon, 6 Nov 2023 09:58:38 -0500 Subject: [PATCH 2/5] Update description of is_secure Signed-off-by: Michael Radka --- dictionary.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dictionary.json b/dictionary.json index 0a867e750..5f058e801 100644 --- a/dictionary.json +++ b/dictionary.json @@ -2879,7 +2879,7 @@ "since": "v1.1.0" }, "caption": "Secure", - "description": "The cookie attribute to only send cookies to the server with an encrypted request over the HTTPS protocol.", + "description": "The cookie attribute indicates that cookies are sent to the server only when the request is encrypted using the HTTPS protocol.", "type": "boolean_t" }, "security_descriptor": { From 2ce61c527790e957ef1ceff1088b191a90976934 Mon Sep 17 00:00:00 2001 From: Michael Radka Date: Mon, 6 Nov 2023 10:02:37 -0500 Subject: [PATCH 3/5] Update is_http_only description Signed-off-by: Michael Radka --- dictionary.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dictionary.json b/dictionary.json index 5f058e801..4155a92d8 100644 --- a/dictionary.json +++ b/dictionary.json @@ -1735,7 +1735,7 @@ }, "is_http_only": { "caption": "HTTP Only", - "description": "A cookie attribute to make it inaccessible via JavaScript", + "description": "This attribute prevents the cookie from being accessed via JavaScript.", "type": "boolean_t" }, "is_managed": { From a79fe5979c143c8704161602632a8ba6baaa7447 Mon Sep 17 00:00:00 2001 From: Michael Radka Date: Mon, 6 Nov 2023 11:07:37 -0500 Subject: [PATCH 4/5] Update is_secure description Signed-off-by: Michael Radka --- dictionary.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dictionary.json b/dictionary.json index 4155a92d8..f0a9c58d7 100644 --- a/dictionary.json +++ b/dictionary.json @@ -1775,7 +1775,7 @@ }, "is_secure": { "caption": "Secure", - "description": "The cookie attribute to only send cookies to the server with an encrypted request over the HTTPS protocol.", + "description": "The cookie attribute indicates that cookies are sent to the server only when the request is encrypted using the HTTPS protocol.", "type": "boolean_t" }, "is_superseded": { From 5825353592bd221e2bceb240e1b0b7d26d1f49dc Mon Sep 17 00:00:00 2001 From: Michael Radka Date: Mon, 6 Nov 2023 11:08:49 -0500 Subject: [PATCH 5/5] Rever desc of deprecated 'secure' attribute for posterity Signed-off-by: Michael Radka --- dictionary.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dictionary.json b/dictionary.json index f0a9c58d7..de59fc58d 100644 --- a/dictionary.json +++ b/dictionary.json @@ -2879,7 +2879,7 @@ "since": "v1.1.0" }, "caption": "Secure", - "description": "The cookie attribute indicates that cookies are sent to the server only when the request is encrypted using the HTTPS protocol.", + "description": "The cookie attribute to only send cookies to the server with an encrypted request over the HTTPS protocol.", "type": "boolean_t" }, "security_descriptor": {