Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using Python for simple sleep #16

Open
ignatenkobrain opened this issue Jul 7, 2019 · 1 comment
Open

Avoid using Python for simple sleep #16

ignatenkobrain opened this issue Jul 7, 2019 · 1 comment

Comments

@ignatenkobrain
Copy link

shared_child.rs/src/lib.rs

Lines 240 to 244 in 8ca2d65

pub fn sleep_forever_cmd() -> Command {
let mut cmd = Command::new("python");
cmd.arg("-c").arg("import time; time.sleep(1000000)");
cmd
}

Isn't sleep enough?

@oconnor663
Copy link
Owner

These tests need to work on Windows, so just using /usr/bin/sleep won't work. It probably would be cleaner to use included Rust binaries though. Whatever we decide to do with oconnor663/duct.rs#73 and oconnor663/os_pipe.rs#18, we should probably replicate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants