fix: add check for FORCE_VERSION_CACHE_UPDATE env variable #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
requested changes
Feb 28, 2023
src/hooks/init/check-update.ts
Outdated
| @@ -44,6 +44,7 @@ const hook: Hook<'init'> = async function ({config}) { | |||
| } | |||
|
|
|||
| const refreshNeeded = async () => { | |||
| if (process.env.FORCE_VERSION_CACHE_UPDATE) return true | |||
There was a problem hiding this comment.
Can you make this a scoped env var, by doing this?
if (this.config.scopedEnvVarTrue('FORCE_VERSION_CACHE_UPDATE')) return true
this.config has a few scopedEnvVar methods that append the cli's name to the env var. So for heroku it would be HEROKU_FORCE_VERSION_CACHE_UPDATE and for sf it would be SF_FORCE_VERSION_CACHE_UPDATE
There was a problem hiding this comment.
Sure thing! Thanks.
mdonnalley
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for a FORCE_VERSION_CACHE_UPDATE environment variable in order to force a cache refresh.
Would allow for a solution to a bug on the Heroku CLI.