Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(topics): avoid recomputing topics in loop #189

Merged
merged 1 commit into from
Feb 3, 2021
Merged

perf(topics): avoid recomputing topics in loop #189

merged 1 commit into from
Feb 3, 2021

Conversation

rbergman
Copy link
Contributor

Aims to fix or improve #101

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @rbergman to sign the Salesforce.com Contributor License Agreement.

@rbergman rbergman force-pushed the improve-topic-performance branch from ad378e6 to 8442d37 Compare January 21, 2021 21:01
@RasPhilCo
Copy link
Contributor

RasPhilCo commented Feb 3, 2021 •
edited
Loading

Hey Bob! Good to see ya, hope all is well! Thanks for the PR.

RasPhilCo
RasPhilCo approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@RasPhilCo RasPhilCo merged commit eccb862 into oclif:master Feb 3, 2021
oclif-bot added a commit that referenced this pull request Feb 3, 2021
@oclif-bot
chore(release): 3.2.2 [skip ci]
f80d96b 
## [3.2.2](v3.2.1...v3.2.2) (2021-02-03)

### Bug Fixes

* avoid recomputing topics in loop ([#189](#189)) ([eccb862](eccb862)), closes [#101](#101)
@Omrisnyk Omrisnyk mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasPhilCo RasPhilCo RasPhilCo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbergman @RasPhilCo