files attribute must be specified check

[moltar]

Trying to understand what is the rationale for this check.

core/src/config/plugin.ts

Line 173 in 6062edf

if (!isProd() && !this.pjson.files) this.warn(`files attribute must be specified in ${pjsonPath}`)

I think it is valid to have no files, and it is possible to craft .npmignore in a way that will provide the same functionality in the end.

Is there any particular reason Oclif needs files to be set?

[mdonnalley]

That check was added way back in 2018: oclif/config@cc73cb5

Unfortunately, I'm not sure why it was added. I agree with you that it seems unnecessary, especially since it can be replaced with .npmignore. Feel free to open a PR if you would like to remove it

[moltar]

I opened a PR, but it requires CLA, which also requires to auth GH to Salesforce.

Just not something I am interested in at the moment.

Feel free to just use the PR/commit. I thereby grant full permission to that change 😁

[mdonnalley]

Thanks @moltar - I merged into another open PR which I plan to merge in the next day or so. Thanks for the contribution 🏆