move ts-node to devDependencies

[vorant94]

Describe the bug
For some reason ts-node is included in regular dependencies, which results in annoying warning while using oclif with yarn:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @oclif/core@npm:2.9.3 doesn't provide @types/node (p3ea0d), requested by ts-node
➤ YN0002: │ @oclif/core@npm:2.9.3 doesn't provide typescript (pc0071), requested by ts-node
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 280ms

To Reproduce
Steps to reproduce the behavior:

1. run npx oclif generate mynewcli
2. choose yarn as a package manager
3. re-run yarn install (optionally)
4. See error

Expected behavior
Since the actual code anyway is built to JS, there is no reason to mark ts-node as a regular dependency. It is only used in development and testing... maybe I'm missing something

Screenshots

Environment (please complete the following information):

• OS & version: macOS 13.4.1 (c) (22F770820d)
• Shell/terminal & version zsh 5.9 (x86_64-apple-darwin22.0)

[cristiand391]

Hi @vorant94

ts-node is also used to compile TS plugins at runtime when they are linked, see:
#650

plugin/command loading is done in @oclif/core so it needs ts-node as a dep.

[vorant94]

Hi @vorant94

ts-node is also used to compile TS plugins at runtime when they are linked, see:

#650

plugin/command loading is done in @oclif/core so it needs ts-node as a dep.

Is it acceptable to maybe make it a deepDep then?

[cristiand391]

Is it acceptable to maybe make it a deepDep then?

You mean making ts-node a peerDependency?

[vorant94]

Is it acceptable to maybe make it a deepDep then?

You mean making ts-node a peerDependency?

yeah, sorry for typo

[SuperchupuDev]

any updates on this issue? it's a bit annoying to have ts-node always installed when it doesn't get used by any of my dependencies

[cristiand391]

hey, sorry missed the last response.

AFAIK, npm installs peerDependencies by default unless you do npm i --omit peer:
npm v7 announcement

Maybe we could remove ts-node from @oclif/core as dep and require plugins to have it as a devDep (which already do for bin/dev to work), but that would be a breaking change and might require some refactor to lazy-load ts-node code in core.

[git2gus]

This issue has been linked to a new work item: W-14179298

[mdonnalley]

Closed by #794