From c0ff832f1103b3b3601b2e3b316b27c8dd4a6f1f Mon Sep 17 00:00:00 2001 From: Jeff Dickey <216188+jdxcode@users.noreply.github.com> Date: Sun, 4 Feb 2018 17:07:22 -0800 Subject: [PATCH] fix: remove notify --- package.json | 2 -- src/index.ts | 6 ------ test/notify.test.ts | 14 -------------- yarn.lock | 27 ++------------------------- 4 files changed, 2 insertions(+), 47 deletions(-) delete mode 100644 test/notify.test.ts diff --git a/package.json b/package.json index d031ffa0..d83e646a 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,6 @@ "fs-extra": "^5.0.0", "indent-string": "^3.2.0", "lodash": "^4.17.4", - "node-notifier": "^5.2.1", "password-prompt": "^1.0.4", "semver": "^5.5.0", "strip-ansi": "^4.0.0", @@ -33,7 +32,6 @@ "@types/mocha": "^2.2.48", "@types/nock": "^9.1.2", "@types/node": "^9.4.0", - "@types/node-notifier": "^0.0.28", "@types/read-pkg": "^3.0.0", "@types/semver": "^5.5.0", "@types/strip-ansi": "^3.0.0", diff --git a/src/index.ts b/src/index.ts index 9730629d..b1de97ef 100644 --- a/src/index.ts +++ b/src/index.ts @@ -1,12 +1,10 @@ import * as EventEmitter from 'events' -import {NodeNotifier} from 'node-notifier' import {ActionBase} from './action/base' import deps from './deps' import Errors, {CLIError, Options as ErrorOptions} from './errors' import {ExitError} from './exit' import * as Logger from './logger' -import notify, {Notification, NotificationCallback} from './notify' import Output from './output' import {IPromptOptions} from './prompt' import * as Table from './styled/table' @@ -30,7 +28,6 @@ export const cli = { fatal: errors('fatal'), exit(code = 1, error?: Error) { throw new ExitError(code, error) }, - notify, get prompt() { return deps.prompt.prompt }, get confirm() { return deps.prompt.confirm }, @@ -54,9 +51,6 @@ export { CLIError, Config, ErrorOptions, - NodeNotifier, - Notification, - NotificationCallback, Errors, ExitError, IPromptOptions, diff --git a/test/notify.test.ts b/test/notify.test.ts deleted file mode 100644 index 439489fb..00000000 --- a/test/notify.test.ts +++ /dev/null @@ -1,14 +0,0 @@ -import cli from '../src' - -import {fancy} from './fancy' - -describe('notify', () => { - fancy - .stderr() - .it('shows notification', (_, done) => { - cli.notify({message: 'example notification'}, err => { - cli.warn(err) - done() - }) - }) -}) diff --git a/yarn.lock b/yarn.lock index b32c163f..3ead255c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -57,12 +57,6 @@ dependencies: "@types/node" "*" -"@types/node-notifier@^0.0.28": - version "0.0.28" - resolved "https://registry.yarnpkg.com/@types/node-notifier/-/node-notifier-0.0.28.tgz#86ba3d3aa8d918352cc3191d88de328b20dc93c1" - dependencies: - "@types/node" "*" - "@types/node@*", "@types/node@^9.4.0": version "9.4.0" resolved "https://registry.yarnpkg.com/@types/node/-/node-9.4.0.tgz#b85a0bcf1e1cc84eb4901b7e96966aedc6f078d1" @@ -674,10 +668,6 @@ growl@1.10.3: version "1.10.3" resolved "https://registry.yarnpkg.com/growl/-/growl-1.10.3.tgz#1926ba90cf3edfe2adb4927f5880bc22c66c790f" -growly@^1.3.0: - version "1.3.0" - resolved "https://registry.yarnpkg.com/growly/-/growly-1.3.0.tgz#f10748cbe76af964b7c96c93c6bcc28af120c081" - has-ansi@^0.1.0: version "0.1.0" resolved "https://registry.yarnpkg.com/has-ansi/-/has-ansi-0.1.0.tgz#84f265aae8c0e6a88a12d7022894b7568894c62e" @@ -934,15 +924,6 @@ natural-compare@^1.4.0: version "1.4.0" resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7" -node-notifier@^5.2.1: - version "5.2.1" - resolved "https://registry.yarnpkg.com/node-notifier/-/node-notifier-5.2.1.tgz#fa313dd08f5517db0e2502e5758d664ac69f9dea" - dependencies: - growly "^1.3.0" - semver "^5.4.1" - shellwords "^0.1.1" - which "^1.3.0" - normalize-path@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-1.0.0.tgz#32d0e472f91ff345701c15a8311018d3b0a90379" @@ -1119,7 +1100,7 @@ semver@5.3.0: version "5.3.0" resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f" -semver@^5.3.0, semver@^5.4.1, semver@^5.5.0: +semver@^5.3.0, semver@^5.5.0: version "5.5.0" resolved "https://registry.yarnpkg.com/semver/-/semver-5.5.0.tgz#dc4bbc7a6ca9d916dee5d43516f0092b58f7b8ab" @@ -1133,10 +1114,6 @@ shebang-regex@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3" -shellwords@^0.1.1: - version "0.1.1" - resolved "https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b" - signal-exit@^3.0.2: version "3.0.2" resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d" @@ -1392,7 +1369,7 @@ v8flags@^3.0.0: dependencies: homedir-polyfill "^1.0.1" -which@^1.2.9, which@^1.3.0: +which@^1.2.9: version "1.3.0" resolved "https://registry.yarnpkg.com/which/-/which-1.3.0.tgz#ff04bdfc010ee547d780bec38e1ac1c2777d253a" dependencies: