This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Feature/fixed price #105
Merged
Feature/fixed price #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kremalicious
reviewed
Sep 7, 2020
|
And I was seeing this temp hack being removed in here somewhere, but think latest merge leaves that again https://github.com/oceanprotocol/react/blob/main/example/src/NetworkMonitor.tsx#L12 If we can now get network based on chainId then we can remove the hack indeed |
|
hmmm, actually fixed that, but I think that I was to quick with resolving conflicts and removed it ... |
kremalicious
reviewed
Sep 7, 2020
kremalicious
reviewed
Sep 7, 2020
Co-authored-by: Matthias Kretschmann <[email protected]>
Co-authored-by: Matthias Kretschmann <[email protected]>
kremalicious
approved these changes
Sep 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed publish so it created a pool or adds fixed price. Publish looks like this now
const priceOptions = { price: 10, tokensToMint: 10, type: 'simple', weightOnDataToken: '', liquidityProviderFee: '' }const ddo = await publish(asset as Metadata, priceOptions, 'access', '', '')priceis only used forsimplewhileweightOnDataTokenandliquidityProviderFeeis used only foradvancedI think this should be merged after #104