Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use providerData timeout, if available #585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use providerData timeout, if available #585

wants to merge 2 commits into from

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Dec 20, 2022 •
edited
Loading

Closes #580

To test, use docker image: oceanprotocol/provider:new_timeout
Changes proposed in this PR:

  • add service.timeout to providerData on initialize
  • if event contains timeout in providerData, use that instead of ddo.service.timeout

@alexcos20 alexcos20 self-assigned this Dec 20, 2022
@alexcos20
Copy link
Member Author

@soonhuat - any updates?

@alexcos20 alexcos20 marked this pull request as ready for review January 3, 2023 10:29
@soonhuat
Copy link
Contributor

soonhuat commented Jan 3, 2023 •
edited
Loading

@alexcos20 haven't had chance to test it yet, likely will test it this n next week

@soonhuat
Copy link
Contributor

soonhuat commented Feb 9, 2023

@alexcos20 been briefly test this PR build (happy scenario mostly) for the pass few weeks, seem working as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcos20 alexcos20

Labels
Status: DoNotMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store snapshot of asset timeout into ProviderData and validity based on this timeout
2 participants
@alexcos20 @soonhuat