Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address false claims of a compute order being executed. (OrderExecuted) #381

Open
alexcos20 opened this issue Feb 25, 2022 · 4 comments
Open
Labels

Comments

@alexcos20
Copy link
Member

alexcos20 commented Feb 25, 2022

What happends after a startOrder ?
Consumer will reach out to provider, trying to download file or start a computeJob
And he succeeds.

Nevertheless, we will claim that he never downloaded or start a computeJob, which leads to claim resolving.
How to fix that ?

Proposal: Have a set of ENV vars, that control how Provider creates the proof:

Parameters:
For any kind of proof, we need the following:

  • orderTxId,
  • providerSignature, (Provider signs providerData using it's own private key)
  • consumerData (Consumer parameters that formed the signature message that Provider received)
  • consumerSignature (Consumer signature is passthrough)
  • consumerAddress
  • providerData:
    • For download, we need a JSON object that holds: DID, serviceIndex, fileIndex, downloadedBytes
    • For compute, we need a JSON object that holds: dataset DID, dataset serviceIndex, algo DID, algo serviceIndex, additionalDatasets (DIDs & serviceIndex)
@calina-c
Copy link
Contributor

calina-c commented Mar 9, 2022

Moving to backlog for now, signatures are incompatible and we need to table this for now

@alexcos20 alexcos20 added the Status: Blocked Blocked by dependency, platform requirement, etc (add comment to detail the reason) label Mar 14, 2022
@alexcos20
Copy link
Member Author

Blocked now because we need to refactor signature on the entire backend (ocean.js/py + provider)

@calina-c
Copy link
Contributor

This is done except for the downloadedBytes part.

@LoznianuAnamaria LoznianuAnamaria removed the Status: Blocked Blocked by dependency, platform requirement, etc (add comment to detail the reason) label Jun 27, 2022
@trentmc trentmc changed the title OrderExecuted Address false claims of a compute order being executed. (OrderExecuted) Feb 28, 2023
@mihaisc
Copy link
Contributor

mihaisc commented Sep 24, 2023

@alexcos20 status on this? can we close it?

@LoznianuAnamaria LoznianuAnamaria removed this from the V4 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants