Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some epochs might not get truevals; fix this #3

Closed
alexcos20 opened this issue Jul 27, 2023 · 0 comments · Fixed by #67
Closed

Some epochs might not get truevals; fix this #3

alexcos20 opened this issue Jul 27, 2023 · 0 comments · Fixed by #67

Comments

@alexcos20
Copy link
Member

Right now, we use a simple logic in main.py:

  • get last block -> get epoch for a PredictionContract, then submit trueval for past epoch

But this poses a couple of problems:

  • what if RPC connection drops for 10 mins?
  • what if our sources (binance, kraken, etc) are failing for 10 mins?
  • what if our code fails and docker is restarted?

This can lead to a lot of epochs without truevals, hurting the rewards.

Proposal:
We should use subgraph and always get a list of epochs, per each PredictionContract, without a submitted trueval. (We have epoch status). Then submit truevals for those epochs.

@trentmc trentmc changed the title Submitting truevals Make submitting truevals more reliable Jul 30, 2023
@trentmc trentmc changed the title Make submitting truevals more reliable Some epochs might not get truevals; fix this Jul 30, 2023
@trizin trizin transferred this issue from oceanprotocol-archive/pdr-trueval Aug 1, 2023
@trizin trizin linked a pull request Aug 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant