Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocean.fixedRateExchange.create should return TransactionReceipt #387

Closed
kremalicious opened this issue Oct 21, 2020 · 0 comments · Fixed by #389
Closed

ocean.fixedRateExchange.create should return TransactionReceipt #387

kremalicious opened this issue Oct 21, 2020 · 0 comments · Fixed by #389

Comments

@kremalicious
Copy link
Contributor

Every chain interaction should end with the TransactionReceipt as response, ideally the one for the actual creation of pool/exchange (not the approve transactions)
@alexcos20 alexcos20 linked a pull request Oct 21, 2020 that will close this issue
make create methods subscribable #389
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make create methods subscribable oceanprotocol/ocean.js
1 participant
@kremalicious