Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocean.pool.create & ocean.fixedRateExchange.create should emit step events #386

Closed
kremalicious opened this issue Oct 21, 2020 · 1 comment · Fixed by #389
Closed

ocean.pool.create & ocean.fixedRateExchange.create should emit step events #386

kremalicious opened this issue Oct 21, 2020 · 1 comment · Fixed by #389

Comments

@kremalicious
Copy link
Contributor

Everything happening within these methods triggering user wallet interaction should be separated into different steps which are emitted with the SubscribablePromise like ocean.assets.create
@kremalicious
Copy link
Contributor Author

and both these methods should behave consistent so calls like this become possible without having to deal with both methods completely different: https://github.com/oceanprotocol/react/pull/147/files#diff-a1d74f45f25189bd90ed1f6a5ddeddd5852e3094e7f5235591c27936ecbca230R237-R248

@alexcos20 alexcos20 linked a pull request Oct 21, 2020 that will close this issue
make create methods subscribable #389
Merged
@bogdanfazakas bogdanfazakas mentioned this issue Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make create methods subscribable oceanprotocol/ocean.js
1 participant
@kremalicious