Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard files marked as modified after a simple build #664

Closed
paulo-ocean opened this issue Aug 30, 2024 · 3 comments · Fixed by #744
Closed

Dashboard files marked as modified after a simple build #664

paulo-ocean opened this issue Aug 30, 2024 · 3 comments · Fixed by #744
Assignees
Labels
Type: Enhancement New feature or request

Comments

@paulo-ocean
Copy link
Contributor

The tracking of the dashboard files is still not correct and needs improvement
Starting from a clean branch and doing a simple: npm run build
marks a bunch of dashboard files under /dist/dashboard as modified
But i'm not changing anything on the dashboard or main node sources, i'm just doing a local build
I should not have a bunch of git modified/deleted files (example bellow)
Screenshot from 2024-08-30 09-45-53

@paulo-ocean paulo-ocean added the Type: Enhancement New feature or request label Aug 30, 2024
@paulo-ocean paulo-ocean self-assigned this Aug 30, 2024
@paulo-ocean
Copy link
Contributor Author

i think this one is not valid anymore, cannot reproduce it on latest

@paulo-ocean
Copy link
Contributor Author

reopening as this is still happening... just fork any branch from main, do a npm run build
and we have the dashboard files marked as modified

@paulo-ocean
Copy link
Contributor Author

paulo-ocean commented Oct 30, 2024

reopening as this is still happening... just fork any branch from main, do a npm run build and we have the dashboard files marked as modified

Ok, so its the dashboard hash is out of sync..
We updated the package-lock.json , but not the hash
one change done 2 weeks ago, other 27 days ago... That's why its always giving changes on main...
Screenshot from 2024-10-30 09-30-10
Screenshot from 2024-10-30 09-29-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant