Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileInfo endpoint service name should be updated to match others (camelCase) #517

Closed
paulo-ocean opened this issue Jul 1, 2024 · 1 comment · Fixed by #520
Closed

fileInfo endpoint service name should be updated to match others (camelCase) #517

paulo-ocean opened this issue Jul 1, 2024 · 1 comment · Fixed by #520
Assignees
Labels
Type: Enhancement New feature or request
Milestone

Comments

@paulo-ocean
Copy link
Contributor

paulo-ocean commented Jul 1, 2024

This needs to be aligned with all the others, and use camelCase
so, fileInfo instead of fileinfo
but before, we need to update corresponding service endpoint check on SDK (ocean.js and ocean.py)
on Ocean.js

public async getFileInfo(
    file: UrlFile | Arweave | Ipfs | GraphqlQuery | Smartcontract,
    providerUri: string,
    withChecksum: boolean = false,
    signal?: AbortSignal
...
const path = this.getEndpointURL(serviceEndpoints, 'fileinfo')
      ? this.getEndpointURL(serviceEndpoints, 'fileinfo').urlPath
      : null

References:
oceanprotocol/ocean.js#1831

UPDATE: SDK is now case insensitive for service names, we can restore this

@paulo-ocean paulo-ocean added Type: Bug Something isn't working Type: Enhancement New feature or request and removed Type: Bug Something isn't working labels Jul 1, 2024
@paulo-ocean paulo-ocean self-assigned this Jul 2, 2024
@alexcos20 alexcos20 added this to the alfa release milestone Jul 5, 2024
@alexcos20 alexcos20 linked a pull request Jul 5, 2024 that will close this issue
@paulo-ocean
Copy link
Contributor Author

closed on #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants