Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL validation during publish through provider #318

Closed
alexcos20 opened this issue Jan 13, 2021 · 4 comments · Fixed by #352
Closed

URL validation during publish through provider #318

alexcos20 opened this issue Jan 13, 2021 · 4 comments · Fixed by #352
Assignees
Labels
Priority: High Type: Bug Something isn't working

Comments

@alexcos20
Copy link
Member

alexcos20 commented Jan 13, 2021

Do not use market's microservice to check the published URL, but use ocean.js instead

Market should use ocean.provider.fileinfo (https://github.com/oceanprotocol/ocean.js/blob/main/src/provider/Provider.ts#L81) instead of using it's own endpoint
(https://github.com/oceanprotocol/market/blob/main/src/utils/index.ts#L45)

Once this is done we should remove this endpoint https://fileinfo.oceanprotocol.com

@alexcos20 alexcos20 transferred this issue from oceanprotocol/contracts Jan 13, 2021
@kremalicious
Copy link
Contributor

kremalicious commented Jan 13, 2021

think it's fine using ocean.js directly for checking URL since it's probably some exported method from there. So we might not need to do anything in react hooks for that. So guess we can move this through to market

@kremalicious kremalicious transferred this issue from oceanprotocol/react Jan 13, 2021
@kremalicious kremalicious changed the title React: URL validation during publish URL validation during publish through provider Jan 13, 2021
@kremalicious kremalicious added the Type: Enhancement New feature or request label Jan 13, 2021
@alexcos20
Copy link
Member Author

yeah, I was not sure about react or market.
The function is here: https://github.com/oceanprotocol/ocean.js/blob/main/src/provider/Provider.ts#L76

@alexcos20
Copy link
Member Author

ignore that, let me add a interface to that

@alexcos20
Copy link
Member Author

done in oceanprotocol/ocean.js#542

@kremalicious kremalicious added Type: Bug Something isn't working Priority: High and removed Type: Enhancement New feature or request labels Jan 28, 2021
@bogdanfazakas bogdanfazakas self-assigned this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants