-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL validation during publish through provider #318
Comments
think it's fine using ocean.js directly for checking URL since it's probably some exported method from there. So we might not need to do anything in react hooks for that. So guess we can move this through to |
yeah, I was not sure about react or market. |
ignore that, let me add a interface to that |
done in oceanprotocol/ocean.js#542 |
Do not use market's microservice to check the published URL, but use ocean.js instead
Market should use ocean.provider.fileinfo (https://github.com/oceanprotocol/ocean.js/blob/main/src/provider/Provider.ts#L81) instead of using it's own endpoint
(https://github.com/oceanprotocol/market/blob/main/src/utils/index.ts#L45)
The text was updated successfully, but these errors were encountered: