New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block loop #921

Closed

alexcos20 opened this issue Oct 14, 2022 · 0 comments · Fixed by #928

Assignees

Labels

Priority: Critical Type: Bug

Member

alexcos20 commented Oct 14, 2022 •

edited

Loading

The current block processing loop is having a lot of issues because:

uses unnecessary web3 calls when splitting in blocks (what if OrderStarted passes, but ExchangeCreated fails? it will split the chunk in two, and use two additional calls again for OrderStarted, which worked fine)
the events are not processed in the right order (blockchain order), but a hardcoded order, which may lead into issues (assets not existing when transfer is detected, etc)

Proposal:

refactor loop

alexcos20 added Type: Bug Priority: Critical labels

alexcos20 self-assigned this

LoznianuAnamaria mentioned this issue

Nft owner not being updated #905

Closed

LoznianuAnamaria linked a pull request

that will close this issue

refactor main loop #928

Merged

3 tasks

alexcos20 closed this as completed in #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment