[new release] dune-build-info and dune (1.11.2) #14705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Remove the optimisation of passing `-nodynlink` for executalbes when not necessary. It seems to be breaking things (see ocaml/dune#2527, @diml) - Fix invalid library names in `dune-package` files. Only public names should exist in such files. (ocaml/dune#2558, fix ocaml/dune#2425, @rgrinberg)
|
Looks good, thanks a lot! |
☀️ All lint checks passed a5cba7b
☀️ Installability check (+2)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed build informations inside executable
CHANGES:
Remove the optimisation of passing
-nodynlinkfor executalbes whennot necessary. It seems to be breaking things (see dune 1.11.0 fails to build on armv7 with odd relocation errors dune#2527, @diml)
Fix invalid library names in
dune-packagefiles. Only public names shouldexist in such files. (Use public names when printing dune files dune#2558, fix default_implementation should enforce public_name dune#2425, @rgrinberg)