Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders starting with underscore on github pages #955

Closed
hbr opened this issue Apr 19, 2023 · 6 comments
Closed

Folders starting with underscore on github pages #955

hbr opened this issue Apr 19, 2023 · 6 comments
Labels
wontfix This will not be worked on

Comments

@hbr
Copy link

hbr commented Apr 19, 2023

I have run into the following problem. I have an ocaml project where I generate the documentation with odoc. odoc generates the directory _odoc_support where files like odoc.css etc. are put.

Unfortunately github pages with jekyll considers directories starting with underscore as special and does not copy them to the final site. In that case the rendering of the documentation does not look nice.

I have found a workaround by putting an empty file called .nojekyll at the root of my github pages. But in the long run it would be better if odoc did not generate directories starting with underscore.

Regards
Helmut

@dbuenzli
Copy link
Contributor

But in the long run it would be better if odoc did not generate directories starting with underscore.

We need a name that cannot be accessed via the module or .mld namespace. The current name satisfies this property. I'm not sure there's really better alternative here.

Given that other people with other systems seem to struggle with this I'd rather say the problem is with jekyll here.

@jonludlam
Copy link
Member

odoc itself supports putting the support files wherever you like - it's up to the driver to tell odoc to do that though. I'm guessing you're using dune to create the docs? In which case, dune could be updated to be able to specify the location of the support directory.

@jonludlam
Copy link
Member

@hbr
Copy link
Author

hbr commented Apr 19, 2023

odoc itself supports putting the support files wherever you like - it's up to the driver to tell odoc to do that though. I'm guessing you're using dune to create the docs? In which case, dune could be updated to be able to specify the location of the support directory.

I am using dune 3.7.1 which is the most recent version. How can I tell dune the location of the support directory?

@jonludlam
Copy link
Member

You can't, it's hardcoded right now - see my link above. Dune would need modification in order to do this, so your issue is with dune, not odoc :-) I'll close this, but feel free to make an issue for dune.

@dbuenzli
Copy link
Contributor

For xref there is one here ocaml/dune#7364

@dbuenzli dbuenzli added the wontfix This will not be worked on label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants