Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping problems on windows #89

Closed
ghost opened this issue May 30, 2016 · 4 comments · Fixed by #334
Closed

Escaping problems on windows #89

ghost opened this issue May 30, 2016 · 4 comments · Fixed by #334
Labels

Comments

@ghost
Copy link

ghost commented May 30, 2016

The Camlp4 build keeps on breaking on Windows due to escaping problems as reported on camlp4/camlp4#41. There was a workaround but it seems that it doesn't work anymore. How are we supposed to escape things with ocamlbuild on windows?

@gasche
Copy link
Member

gasche commented May 30, 2016

I would be happy to fix these issues (there should be no workaround needed on the user side), but the main issue I think is that I don't have reliable testing done on Windows. @diml , how are you doing your testing, do you have ssh-like access to a Windows machine? I'm thinking of investing my short-term maintenance budget into shaping a serious ocamlbuild test suite (including the current tests plus some complete builds of simple projects), and trying to get some kind of Windows CI for it. I would be happy to work with feedback from Windows users, and it would let me act on change proposals such as #70 that are currently stalled by lack of Windows feedback.

@ghost
Copy link
Author

ghost commented May 31, 2016

I haven't been testing camlp4 on Windows so far. I have access to Windows machines at work so I can run some tests. For Windows CI AppVeyor seems to be popular. I want to look at it for various projects at some point

@msprotz
Copy link

msprotz commented Jun 1, 2016

I'm surprised because I didn't see any changes happen in ocamlbuild that would be related to quoting...

I can try building camlp4 with the old toolchain but that's ugly.

@msprotz
Copy link

msprotz commented Jun 1, 2016

Edit: you can't build camlp4 4.X with OCaml 4.Y (and X <> Y).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants