Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlbuild.0.9.1 : hygiene check does not exclude _build in Win32 #71

Closed
camlspotter opened this issue Apr 13, 2016 · 4 comments
Closed

ocamlbuild.0.9.1 : hygiene check does not exclude _build in Win32 #71

camlspotter opened this issue Apr 13, 2016 · 4 comments
Labels
bug

Comments

@camlspotter
Copy link

See ocaml/opam-repository#6224 for details.

I think it is since My_std.fiilename_concat uses / in any OS.
@camlspotter
Copy link
Author

Another glitch: My_std.sys_command gets c:\cygwin\...\myocamlbuild.exe and failed to execute using bash. \ must be replaced by / here...

The function is not different from ocamlbuild of ocaml.4.02.3. Changes somewhere else caused this issue...

@gasche
Copy link
Member

gasche commented Apr 13, 2016

#70 should solve the first reported problem once the relevant parts are merged.

@camlspotter
Copy link
Author

Hmm, I made a workaround of one line diff but yeah, we should have real fixes rather than workarounds. Thanks.

@gasche
Copy link
Member

gasche commented Apr 30, 2016

I pushed a tentative first fix in master: b29023c . Could you maybe try to check if it solves the problem on your Windows machine?

@whitequark whitequark added the bug label Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @camlspotter @gasche