Use public names when printing dune files #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
default-impl-name
branch
from
1d94031 to
677fe24
Compare
ghost
reviewed
Aug 19, 2019
ghost
suggested changes
Aug 19, 2019
rgrinberg
force-pushed
the
default-impl-name
branch
2 times, most recently
from
6706628 to
ee08f69
Compare
Default implementations should always use the public name Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
The library that was used for default-implementation didn't exist previously and our error checking was lax. Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
default-impl-name
branch
from
ee08f69 to
c95fe4e
Compare
|
Thanks for the review. I addressed your comments. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Aug 20, 2019
CHANGES: - Remove the optimisation of passing `-nodynlink` for executalbes when not necessary. It seems to be breaking things (see ocaml/dune#2527, @diml) - Fix invalid library names in `dune-package` files. Only public names should exist in such files. (ocaml/dune#2558, fix ocaml/dune#2425, @rgrinberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2425 and the bug @NathanReb encountered with @avsm.