Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: Print all the depexts #11145

Merged
merged 3 commits into from
Nov 22, 2024
Merged

pkg: Print all the depexts #11145

merged 3 commits into from
Nov 22, 2024

Conversation

moyodiallo
Copy link
Collaborator

Fixes #11000, this PR introduce dune pkg depexts which print all the depexts of a dune-project.

rgrinberg
rgrinberg requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the printing functions under dune show pkg. I'd suggest you move this one there as well.

@moyodiallo
Copy link
Collaborator Author

We already have the printing functions under dune show pkg. I'd suggest you move this one there as well.

Great, I missed that.

@moyodiallo
Copy link
Collaborator Author

We already have the printing functions under dune show pkg. I'd suggest you move this one there as well.

Done here.

moyodiallo and others added 3 commits November 22, 2024 15:19
@moyodiallo @Leonidas-from-XIV
pkg: Print all the depexts
fa01f47 
Signed-off-by: moyo <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV
Move modules around to be more consistent
4bd6388 
Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV
Simplify test
12ef143 
Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV
Copy link
Collaborator

I've moved the modules around and simplifed the test. It's fairly simple and doesn't need much setup :-)

@rgrinberg rgrinberg merged commit b7a54f2 into ocaml:main Nov 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrinberg rgrinberg rgrinberg approved these changes

@maiste maiste Awaiting requested review from maiste

Assignees
No one assigned
Labels
package management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dune developer preview: automatic depext handling?
3 participants
@moyodiallo @Leonidas-from-XIV @rgrinberg