Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd tests for cache trimming priority in the [copy] mode #6028

Open
Blaisorblade opened this issue Aug 1, 2022 · 1 comment
Open

Readd tests for cache trimming priority in the [copy] mode #6028

Blaisorblade opened this issue Aug 1, 2022 · 1 comment

Comments

@Blaisorblade
Copy link
Contributor

Those tests were removed in #4511, and #4497 (comment) already hinted at concrete problems.

@Blaisorblade
Copy link
Contributor Author

FTR, using a cache entry by opening it read-only (as done in copy mode) should not update its ctime, unlike creating hardlinks — that's according to the POSIX standard (or Mac/Linux man pages).
https://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html

However, I could still have missed code in restore_artifacts that touches permissions in other ways. I'll try to test this myself if nobody confirms the problem first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant