Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent newlines across platforms #3762

Closed
johnwhitington opened this issue Sep 4, 2020 · 3 comments
Closed

Inconsistent newlines across platforms #3762

johnwhitington opened this issue Sep 4, 2020 · 3 comments

Comments

@johnwhitington
Copy link

#Expected Behavior

Dune screen output the same on different platforms

Actual Behavior

Dune screen output on OS X / Windows differs

Reproduction

OS X:

gorge:Desktop john$ dune init exe helloworld
Success: initialized executable component named helloworld
gorge:Desktop john$

Windows:

John Whitington@DESKTOP-OJQME0H ~/helloworld
$ dune init exe helloworld
Success: initialized executable component named helloworld
     <--- **extra newline here**
John Whitington@DESKTOP-OJQME0H ~/helloworld

OS X:

gorge:helloworld john$ dune build
Info: Creating file dune-project with this contents:
| (lang dune 2.7)
Done: 8/11 (jobs: 1)gorge:helloworld john$ <---- ***missing newline here***

Windows:

John Whitington@DESKTOP-OJQME0H ~/helloworld
$ dune build
Info: Creating file dune-project with this contents:
| (lang dune 2.7)
Done: 8/11 (jobs: 1)
John Whitington@DESKTOP-OJQME0H ~/helloworld

Specifications

  • Version of dune (output of dune --version): 2.7.0
  • Version of ocaml (output of ocamlc --version) 4.11.1
  • Operating system (distribution and version): OS X Catalina / Windows 10 x64 with OCaml from https://fdopen.github.io/opam-repository-mingw/
@johnwhitington
Copy link
Author

See also #3737

@ian-barnes
Copy link

ian-barnes commented Sep 7, 2020

Linux behaviour is the same as for OS X:

ian@ian-laptop:09:52:45:~/hello$ dune init exe helloworld
Success: initialized executable component named helloworld
ian@ian-laptop:09:52:49:~/hello$ dune build
Info: Creating file dune-project with this contents:
| (lang dune 2.7)
Done: 8/11 (jobs: 1)ian@ian-laptop:09:52:53:~/hello$  <---- ***missing newline here***
ian@ian-laptop:09:52:55:~/hello$ dune --version
2.7.0
ian@ian-laptop:09:53:03:~/hello$ ocamlc --version
4.10.0
ian@ian-laptop:09:53:11:~/hello$ cat /etc/debian_version 
bullseye/sid

@nojb
Copy link
Collaborator

nojb commented Oct 2, 2020

There are two issues here as I understand: 1) on Windows, the Cygwin prompt includes a newline prefix which explains the difference between Windows and Linux/OS X, and 2) a missing newline after the status indicator #3737.

  1. is a shell configuration issue, not directly related to dune, and
  2. should have been fixed in Fix issue #3737 #3767.

Closing this, feel free to re-open if needed. Thanks!

@nojb nojb closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants