Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message from virtual modules doesnt point to the right executable #1717

Closed
avsm opened this issue Dec 27, 2018 · 0 comments
Closed

error message from virtual modules doesnt point to the right executable #1717

avsm opened this issue Dec 27, 2018 · 0 comments

Comments

@avsm
Copy link
Member

avsm commented Dec 27, 2018

With a port of tcpip to use dune-master virtual libraries, it all works except that if an executable doesnt define an implementation, the error message points to somewhere else in the compilation stack.

e..g with this

(executables
 (names ping)
 (libraries cmdliner logs logs.fmt tcpip.icmpv4-socket))

the error message from dune is

$ dune build @all
Error: No implementation found for virtual library "tcpip-checksum" (_build/default/src/tcpip_checksum).
      -> required by library "tcpip.icmpv4" in _build/default/src/icmp

It would be nice if the error message pointed to the "root cause" which is the executable clause, not the dependent library in tcpip.icmpv4.

(PS: virtual modules rock! hurrah! The tcpip PR is at mirage/mirage-tcpip#384)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant