Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ocaml/dune
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c96f58cfa3d14937ad3d4de24ba91ffdb058fa89
Choose a base ref
..
head repository: ocaml/dune
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2d257a711d913fef6946b9acd73c696ad7f04b2
Choose a head ref
Showing with 4 additions and 5 deletions.
  1. +3 −1 src/dune_rules/lib.ml
  2. +1 −4 src/dune_rules/scope.ml
4 changes: 3 additions & 1 deletion src/dune_rules/lib.ml
View file
Original file line number Diff line number Diff line change
@@ -1719,7 +1719,9 @@ module DB = struct
|> Lib_info.of_local
in
match conf.visibility with
| Private _ -> [ (Dune_file.Library.best_name conf, Found_or_redirect.found info) ]
| Private _ ->
[ (Dune_file.Library.best_name conf, Found_or_redirect.found info)
]
| Public p ->
let name = Dune_file.Public_lib.name p in
if Lib_name.equal name (Lib_name.of_local conf.name) then
5 changes: 1 addition & 4 deletions src/dune_rules/scope.ml
View file
Original file line number Diff line number Diff line change
@@ -80,10 +80,7 @@ module DB = struct
->
named (Dune_file.Public_lib.name p) loc
| Deprecated_library_name
{ Dune_file.Library_redirect.loc
; old_name = (p, _)
; _
} ->
{ Dune_file.Library_redirect.loc; old_name = p, _; _ } ->
Option.some_if (name = Dune_file.Public_lib.name p) loc
| _ -> None)
with