Skip to content

Commit

Permalink
Promote more consistent behaviour of overlap checks
Browse files Browse the repository at this point in the history
Signed-off-by: Ulysse Gérard <[email protected]>
  • Loading branch information
voodoos committed Oct 9, 2024
1 parent 0348829 commit 97334c1
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion test/blackbox-tests/test-cases/overlapping-deps.t
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ We can fix the error by allow overlapping dependencies:
> EOF
$ OCAMLPATH=$PWD/../external/_build/install/default/lib dune build %{cma:proj2/bar} --root .

Strangely, the error disappears if we remove the source for the bar lib:
The error does not disappears if we remove the source for the bar lib:

$ cat >proj2/dune <<EOF
> (library
Expand All @@ -90,6 +90,16 @@ Strangely, the error disappears if we remove the source for the bar lib:
> EOF
$ rm proj2/bar.ml
$ OCAMLPATH=$PWD/../external/_build/install/default/lib dune build %{cma:proj2/bar} --root .
Error: Conflict between the following libraries:
- "some_package2" in _build/default/proj1
- "some_package2" in
$TESTCASE_ROOT/use/../external/_build/install/default/lib/some_package2
-> required by library "some_package1" in
$TESTCASE_ROOT/use/../external/_build/install/default/lib/some_package1
-> required by _build/default/proj2/.merlin-conf/lib-bar
-> required by _build/default/proj2/bar.cma
-> required by %{cma:proj2/bar} at command line:1
[1]

We also make sure the error exists for executables:
$ cat >proj2/dune <<EOF
Expand Down

0 comments on commit 97334c1

Please sign in to comment.