Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove windows hack for running scripts in build actions #454

Closed
jberdine opened this issue Oct 8, 2018 · 4 comments
Closed

Remove windows hack for running scripts in build actions #454

jberdine opened this issue Oct 8, 2018 · 4 comments

Comments

@jberdine
Copy link
Collaborator

jberdine commented Oct 8, 2018

Revert #448 once dune is able to hide window's inability to run scripts.
@gpetiot gpetiot mentioned this issue Oct 26, 2018
Closed
@jberdine jberdine mentioned this issue Jan 22, 2019
Closed
@gpetiot
Copy link
Collaborator

gpetiot commented Mar 28, 2019

Fixed by #664 ?

@jberdine
Copy link
Collaborator Author

It's not really fixed. There is still the %%{dep stuff needed in the dune file since we're not allowed to make gen_version.ml a shebang script either.

@Julow
Copy link
Collaborator

Julow commented Sep 4, 2019

@jberdine The %{dep:...} syntax is to tell dune what are the dependencies. The real "hack" is calling the interpreter explicitly: ocaml %{dep:...}.
I don't think that is an uncommon way to call a script. What do you think?

@emillon emillon mentioned this issue Nov 7, 2019
Merged
@gpetiot
Copy link
Collaborator

gpetiot commented Sep 30, 2021

Closed by #1133

@gpetiot gpetiot closed this as completed Sep 30, 2021
@jberdine jberdine reopened this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpetiot @jberdine @Julow