Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: exceeding line limit of 90 characters #1061

Closed
ceastlund opened this issue Oct 9, 2019 · 0 comments · Fixed by #1064
Closed

Bug: exceeding line limit of 90 characters #1061

ceastlund opened this issue Oct 9, 2019 · 0 comments · Fixed by #1064

Comments

@ceastlund
Copy link

Describe the bug
We used to get this formatting with 0.10:

module type Basic3 = sig
  type ('a, 'd, 'e) t

  val return : 'a -> ('a, _, _) t
  val apply : ('a -> 'b, 'd, 'e) t -> ('a, 'd, 'e) t -> ('b, 'd, 'e) t

  val map
    : [ `Define_using_apply
      | `Custom of ('a, 'd, 'e) t -> f:('a -> 'b) -> ('b, 'd, 'e) t
      ]
end

We now get this formatting with 0.11. The type for map goes over the normal line limit of 90 characters.

module type Basic3 = sig
  type ('a, 'd, 'e) t

  val return : 'a -> ('a, _, _) t
  val apply : ('a -> 'b, 'd, 'e) t -> ('a, 'd, 'e) t -> ('b, 'd, 'e) t

  val map
    : [ `Define_using_apply | `Custom of ('a, 'd, 'e) t -> f:('a -> 'b) -> ('b, 'd, 'e) t ]
end

How to Reproduce
Using ocamlformat built from 962afbc, run:
ocamlformat --enable-outside-detected-project --profile=janestreet --inplace applicative_intf.ml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants