Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get monitors #647

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Remove get monitors #647

merged 1 commit into from
Oct 4, 2016

Conversation

wt
Copy link
Contributor

@wt wt commented Oct 3, 2016

The functionality around probing for monitors can use Qt instead of a per-platform implementation. That's what this change does.

@wt wt force-pushed the remove_GetMonitors branch from c97591f to ffceffd Compare October 3, 2016 04:41
@wt
Copy link
Contributor Author

wt commented Oct 3, 2016

I just updated this PR as I incorrectly implemented the logic pertaining to restoring the previous window location when the app is launch. Everything should be ready to go now.

@wt wt force-pushed the remove_GetMonitors branch from 1688cd0 to d309743 Compare October 4, 2016 05:40
@wt
Copy link
Contributor Author

wt commented Oct 4, 2016

Squashed and updated per our discussion on IRC.

@wt wt force-pushed the remove_GetMonitors branch from d309743 to 5ca809e Compare October 4, 2016 06:48
All of the monitor discovery logic can be implemented with Qt. This
change removes all the x11 implementations in favor of Qt and removes a
fair amount of platform specific code.
@wt wt force-pushed the remove_GetMonitors branch from 5ca809e to f3eb8aa Compare October 4, 2016 06:50
@wt
Copy link
Contributor Author

wt commented Oct 4, 2016

All autos removed.

@jp9000 jp9000 merged commit f816377 into obsproject:master Oct 4, 2016
@reboot
Copy link
Contributor

reboot commented Oct 19, 2016

This change breaks the full screen projector for me on Linux

Error
Left: Current master
Right. After reverting f3eb8aa

jacklinw pushed a commit to epicsf/obs-studio that referenced this pull request Aug 13, 2017
joelvaneenwyk pushed a commit to joelvaneenwyk/obs-studio that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants