Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux: Update Flatpak CEF from 103/5060 to 127/6533 #11218

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

tytan652
Copy link
Collaborator

Description

Flatpak counterpart of #11213

Reminder that obsproject/obs-browser#450 (or an alternative) is required to avoid the shutdown crash with browser docks.

The CEF module is also modified to:

  • Use the pre-built wrapper included in the tarball
  • Preserve debug symbols inside its binaries
    • The copy done later by OBS Studio build-system will be split from its debug symbols

Motivation and Context

Update CEF on the Flatpak and preserve CEF debug symbols which will be put in the .Debug Flatpak extension.

How Has This Been Tested?

Build with CEF and debug symbols are generated and compressed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The CEF module is also modified to:
- Use the pre-built wrapper included in the tarball
- Preserve debug symbols inside its binaries
  - The copy done later by OBS Studio build-system will be split from
    its debug symbols
@tytan652 tytan652 added Seeking Testers Build artifacts on CI Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Linux Affects Linux labels Aug 29, 2024
@tiberium-v
Copy link

Tested on x11 (i3 wm), via flatpak artifact without problems. Also, Custom Browser Docks Window are behaving normal

@colingourlay
Copy link

colingourlay commented Aug 29, 2024

Looking great on macOS (Sonoma) 14.6.1. Virtual camera has stopped working, but browser sources are all perfect. Tested recent Chromium features by using CSS mask-image to mask areas of the page with an local SVG <mask>. Flawless! Thank you so much for this update.

@RytoEX RytoEX self-assigned this Aug 30, 2024
@RytoEX
Copy link
Member

RytoEX commented Aug 30, 2024

Looking great on macOS (Sonoma) 14.6.1. Virtual camera has stopped working, but browser sources are all perfect. Tested recent Chromium features by using CSS mask-image to mask areas of the page with an local SVG <mask>. Flawless! Thank you so much for this update.

As a note, this PR only updates the Flatpak version. PR #11213 updates Windows and macOS.

@RytoEX RytoEX added this to the OBS Studio 31 milestone Aug 30, 2024
@RytoEX
Copy link
Member

RytoEX commented Aug 30, 2024

This should now be unblocked by 16011f7.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit b7dbaf4 into obsproject:master Aug 31, 2024
14 checks passed
@tytan652 tytan652 deleted the update-fp-cef-to-127 branch August 31, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Linux Affects Linux Seeking Testers Build artifacts on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants