Add plugin: Custom Image Auto Uploader

[haierkeys]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/haierkeys/obsidian-custom-image-auto-uploader

Release Checklist

• I have tested the plugin on

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

• My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)

  • main.js
  • manifest.json

• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)

• The id in my manifest.json matches the id in the community-plugins.json file.

• My README.md describes the plugin's purpose and provides clear usage instructions.

• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.

• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.

• I have added a license in the LICENSE file.

• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1][2]:You should change all instances of var to either const or let. var has function-level scope, so it can easily lead to bugs if you're not careful. Here's a pretty good guide with examples of why not to use var: why var is obsolete

---

Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[ObsidianReviewBot]

Changes requested by bot have been made, assigning human for additional review.

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: yy4382/obsidian-image-upload. If you are submitting from a GitHub org, you need to be a public member of the org.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}

[haierkeys]

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: yy4382/obsidian-image-upload. If you are submitting from a GitHub org, you need to be a public member of the org.

This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

OK, It has been modified.

[joethei]

Copyright (c) 2021 Kirill Gavrilov
Update this.

new Setting(set).setName($("通用")).setHeading();
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

src: "https://cdn.ko-fi.com/cdn/kofi3.png?v=3"
This has to be bundled into the plugin, not loaded from an external source.

let folder = await plugin.app.fileManager.getAvailablePathForAttachment("");
Please use the function properly and pass in the filename and the path to the file that's currently open, then return the result of the function, and remove the other two lines.
The way you are currently using the API will result in the wrong folder being used for attachments if the user has configured it in a certain way.

"Image Api Gateway 地址": "Image API Gateway address",
Use sentence case in UI

[haierkeys]

Thanks for the feedback. The requested changes have been made.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

---

Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.

---

Do NOT open a new PR for re-validation.

[joethei]

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number.

let loadedFiles = plugin.app.vault.getAllLoadedFiles();
Use the getFirstLinkpathDest instead of iterating over all files.

[haierkeys]

"minAppVersion": "0.15.0", You are using newer API's, set this to the latest public build number.

let loadedFiles = plugin.app.vault.getAllLoadedFiles(); Use the getFirstLinkpathDest instead of iterating over all files.

ok, The requested changes have been made

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

---

Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.

---

Do NOT open a new PR for re-validation.

[haierkeys]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.

Do NOT open a new PR for re-validation.

Changes made.. https://github.com/haierkeys/obsidian-custom-image-auto-uploader/tree/1.5.8

[haierkeys]

@joethei How long will the review take? Is there anything else that needs to be modified?

[github-actions]

Hello!

I found the following issues in your plugin submission

Errors:

❌ There is already a plugin with the id custom-image-auto-uploader.
❌ There is already a plugin with the name Custom Image Auto Uploader.
❌ There is already a entry pointing to the haierkeys/obsidian-custom-image-auto-uploader repository.

---

^{This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.}