Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Wardley Maps #4616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damonsk
Copy link

@damonsk damonsk commented Nov 4, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/damonsk/obsidian-wardley-maps

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Nov 4, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.6. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Update community-plugins.json for Wardley Maps Add plugin: Wardley Maps Nov 4, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should change all instances of var to either const or let. var has function-level scope, so it can easily lead to bugs if you're not careful. Here's a pretty good guide with examples of why not to use var: why var is obsolete


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Nov 5, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 5, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Nov 6, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Nov 15, 2024

To make the manual review process and future plugin maintenance more efficient, we recommend that you move all source code files into a src directory.

# Obsidian Wardley Maps Plugin
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

"description": "View and edit Wardley Maps in Obsidian using the Online Wardley Maps format.",
Don't include "Obsidian" in the description, that should be a given since this only displayed when browsing plugins in the app / on our website.

await this.loadSettings();
Your plugin does not have any settings, so remove this loading code.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Nov 15, 2024
damonsk added a commit to damonsk/obsidian-wardley-maps that referenced this pull request Nov 16, 2024
damonsk added a commit to damonsk/obsidian-wardley-maps that referenced this pull request Nov 16, 2024
@damonsk
Copy link
Author

damonsk commented Nov 16, 2024

Work done thank you.

@damonsk
Copy link
Author

damonsk commented Nov 28, 2024

@joethei mindful it's been a while. Anything more required to progress this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants