-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Image links are broken because of appended .md #39
Comments
Image with Also, could you please share the file contents ? Maybe I forgot to set the |
I'm on a Mac. I updated the image file name to remove extra periods and see the same issue.
A link to the actual .jpg is here The same problem is observed with .jpg files as well. |
Strange. Do you have a obsidian md file example ? I didn't have this on my side, so I don't understand :w |
EDIT: I successfull repro the problem without regex. |
Can we keep the issue open so I can be notified when it's fixed to retest. Thanks! |
It's literally fixed in the last release |
oops..didn't realize it. I just tested it and it's working. Thanks so much! |
Issue validation
Workflow
Obsidian plugin 💠
Describe the bug
Images are broken when published because the image URL has .md appended to the end.
Example:
After publishing to GitHub from Obsidian, a note has the following reference too an image file:
![Paper.Journal.1.jpeg](../images/obsidian/Paper.Journal.1.jpeg.md)
This results in a broken image icon instead of the actual image.
Changing it to:
![Paper.Journal.1.jpeg](../images/obsidian/Paper.Journal.1.jpeg)
fixes the issue and the image shows as expected.
How to reproduce ?
No response
Configuration
{
"githubRepo": "blog",
"githubName": "me",
"GhToken": "token",
"githubBranch": "main",
"shareKey": "share",
"shareKey": "share",
"ExcludedFolder": "",
"fileMenu": true,
"editorMenu": true,
"downloadedFolder": "fixed",
"folderDefaultName": "obsidian",
"yamlFolderKey": "category",
"rootFolder": "docs",
"workflowName": "",
"embedImage": true,
"defaultImageFolder": "images/obsidian",
"autoCleanUp": true,
"autoCleanUpExcluded": "docs/assets/js, docs/assets/meta, docs/assets/css, tags.md",
"folderNote": true,
"convertWikiLinks": true,
"convertForGithub": true,
"subFolder": "",
"embedNotes": false,
"copyLink": false,
"mainLink": "",
"linkRemover": "",
"hardBreak": false,
"logNotice": true,
"convertDataview": false,
"useFrontmatterTitle": false,
"censorText": [
{
"entry": "(?<!\\
)\\\\[(.*?)\\\\]\\\\((?!(http|\\\\/*image|obsidian\\\\/image))(\\\\.\\\\/)*(.+?)(\\\\.md)*\\\\) ", "replace": "[$1]({% link obsidian/$4.md %})", "after": false }, { "entry": "(?<!\\\\
)\\[(.*?)\\]\\(((obsidian\\/)?image)(.+)\\)","replace": "$1",
"after": false
}
],
"inlineTags": false,
"dataviewFields": [],
"excludeDataviewValue": [],
"metadataFileFields": [],
"frontmatterTitleKey": "title",
"shareExternalModified": false
}
Relevant log output
No response
OS
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: