fix(settings): fix graphical bugs with yaml settings and add translat…

…ion for error
Enveloppe · Aug 24, 2023 · ca14104 · ca14104
1 parent d05a5de
commit ca14104
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
@@ -77,6 +77,7 @@
     "success": "Successfully deleted {{- nb}} files."
   },
   "error": {
+    "autoClean": "The default folder is empty, auto-cleaning will be disabled.",
     "dataview": "Unable to render dataview query. Please update the dataview plugin to the last version.",
     "errorConfig": "Error configuring {{- repo.owner}}/{{- repo.repo}}. Please check your settings.",
     "errorPublish": "Error during upload to {{- repo.owner}}/{{- repo.repo}}",

diff --git a/src/i18n/locales/fr.json b/src/i18n/locales/fr.json
@@ -77,6 +77,7 @@
     "success": "Suppression réussie de {{- nb}} fichiers."
   },
   "error": {
+    "autoClean": "Le dossier par défaut est vide, l'auto-nettoyage sera désactivée.",
     "dataview": "Impossible de convertir la requête Dataview. Veuillez mettre à jour le module Dataview à la dernière version;",
     "errorConfig": "Erreur de configuration pour {{- repo.owner}}/{{- repo.repo}}:{{- repo.branch}}. Merci de vérifier vos paramètres.",
     "errorPublish": "Erreur lors de la publication sur {{- repo.owner}}/{{- repo.repo}}:{{- repo.branch}}",

diff --git a/src/settings.ts b/src/settings.ts
@@ -431,7 +431,7 @@ export class GithubPublisherSettingsTab extends PluginSettingTab {
 							this.plugin
 						);
 						await this.plugin.saveSettings();
-						this.renderUploadConfiguration();
+						this.renderSettingsPage(EnumbSettingsTabId.upload);
 					});
 			});
 		const frontmatterTitleSet = new Setting(this.settingsPage)
@@ -500,7 +500,7 @@ export class GithubPublisherSettingsTab extends PluginSettingTab {
 					.onChange(async (value) => {
 						uploadSettings.folderNote.enable = value;
 						await this.plugin.saveSettings();
-						this.renderSettingsPage("upload-configuration");
+						this.renderSettingsPage(EnumbSettingsTabId.upload);
 					});
 			});
 

diff --git a/src/settings/style.ts b/src/settings/style.ts
@@ -1,3 +1,4 @@
+import i18next from "i18next";
 import { Notice, Setting } from "obsidian";
 
 import GithubPublisherPlugin from "../main";
@@ -66,7 +67,7 @@ export async function autoCleanCondition(
 ) {
 	const settings = plugin.settings.upload;
 	if (value.length === 0 && settings.defaultName) {
-		new Notice("The default folder is empty, the autoclean settings will be disabled");
+		new Notice(i18next.t("error.autoClean"));
 		settings.autoclean.enable = false;
 		await plugin.saveSettings();
 		autoCleanSetting.setDisabled(true);
@@ -78,7 +79,7 @@ export async function autoCleanCondition(
 		value.length === 0 &&
 		settings.behavior !== FolderSettings.yaml
 	) {
-		new Notice("The default folder is empty, the autoclean settings will be disabled");
+		new Notice(i18next.t("error.autoClean"));
 		settings.autoclean.enable = false;
 		autoCleanSetting.setDisabled(true);
 		// @ts-ignore