fix: Cannot read property of null when opening the command palette wi…

…thout file
Enveloppe · Feb 13, 2023 · 5b3d4a4 · 5b3d4a4
1 parent eb9f2c2
commit 5b3d4a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/plugin/main.ts b/plugin/main.ts
@@ -262,10 +262,10 @@ export default class GithubPublisher extends Plugin {
 			name: commands("shareActiveFile") as string,
 			hotkeys: [],
 			checkCallback: (checking) => {
-				const frontmatter = this.app.metadataCache.getFileCache(this.app.workspace.getActiveFile()).frontmatter;
 				const file = this.app.workspace.getActiveFile();
+				const frontmatter = file ? this.app.metadataCache.getFileCache(file).frontmatter : null;
 				if (
-					isShared(frontmatter, this.settings, file)
+					file && frontmatter && isShared(frontmatter, this.settings, file)
 				) {
 					if (!checking) {
 						shareOneNote(

diff --git a/plugin/src/data_validation_test.ts b/plugin/src/data_validation_test.ts
@@ -24,11 +24,11 @@ export function isInternalShared(
  */
 
 export function isShared(
-	meta: FrontMatterCache,
+	meta: FrontMatterCache | null,
 	settings: GitHubPublisherSettings,
 	file: TFile
 ): boolean {
-	if (!file || file.extension !== "md") {
+	if (!file || file.extension !== "md" || meta === null) {
 		return false;
 	}
 	const folderList = settings.plugin.excludedFolder;