PdfLatex custom path not used

[PeteMichaud]

I think I found a quite bad bug, but I want other eyes on it to verify.

There is a setting in the plugin that allows the user to input their own custom path for pdflatex, in case it's not accessible on the user's PATH.

The code that spawns the pandoc process tries to use this path in the following way:

1. Make a copy of the process.env object:
   

   obsidian-pandoc/pandoc.ts

   Line 149 in c8cf21a

   const env = Object.assign(process.env);

2. If a custom pdflatex path is provided, update the copied env object with that new path:

   obsidian-pandoc/pandoc.ts

   Line 159 in c8cf21a

   env.PATH += path.dirname(input.pdflatex);

3. Totally ignore the modified copy, and just pass in the normal process.env anyway:

   obsidian-pandoc/pandoc.ts

   Line 161 in c8cf21a

   pandoc = spawn(input.pandoc || 'pandoc', args, { env: process.env });

So the custom pdflatex path is actually never used, and the only way this plugin can ever generate pdfs is if pdflatex actually is on the user's PATH.

I think the fix is simply to change line 161 to:

pandoc = spawn(input.pandoc || 'pandoc', args, { env: env });

Thoughts?