Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI command error handling #482

Closed
mcglincy opened this issue Jan 10, 2024 · 10 comments
Closed

Improve CLI command error handling #482

mcglincy opened this issue Jan 10, 2024 · 10 comments
Assignees
Labels
bug Something isn’t working

Comments

@mcglincy
Copy link
Contributor

mcglincy commented Jan 10, 2024

EA bug bash: https://observablehq.com/@observablehq/ea-bug-bash

We need dramatically better error handling around CLI deploy errors. At a minimum, we should be catching all unexpected http status errors and showing a more readable/actionable error message to users. (and no stacktraces :P)

See https://oclif.io/.

@mcglincy mcglincy added this to the Early access milestone Jan 11, 2024
@mbostock mbostock added the bug Something isn’t working label Jan 16, 2024
@Fil
Copy link
Contributor

Fil commented Jan 22, 2024

related: #523

@mcglincy
Copy link
Contributor Author

@mythmon - are you doing any of this work as part of the deploy+clack re-tooling you're doing? Or should I revisit this issue once your changes are in place?

@mythmon
Copy link
Member

mythmon commented Jan 30, 2024

Let's re-evaluate this after my changes are in place.

@cinxmo cinxmo modified the milestone: General availability Feb 1, 2024
@cinxmo
Copy link
Contributor

cinxmo commented Feb 1, 2024

We can have a series of pre-deploy checks on top of error handling. I can think of:

  • authentication
  • file size limits (I purposely tested deploying a ~100 mb file and ran into a 413 😅)

@Sylvestre67 Sylvestre67 changed the title Improve deploy command error handling Improve CLI command error handling Feb 2, 2024
@mythmon
Copy link
Member

mythmon commented Feb 2, 2024

Regarding file size limits: we still have a hard limit of 50MB, because after that our HTTP server closes the connection. I don't think it is a high priority to raise that limit, because as Ambassador Yuri said recently regarding that limit: if you're putting files bigger than 50MB in a project, you're making a bad user experience and should think twice about it.

@tophtucker
Copy link
Contributor

michael's #725 adds some plumbing to improve this in general, and resolves the TOO_MANY_PROJECTS case

@mbostock
Copy link
Member

@mythmon @mcglincy @cinxmo What’s the latest on this? This is one of the last outstanding issues for GA and I’m happy to chip in to help with the error-handling if needed.

@cinxmo
Copy link
Contributor

cinxmo commented Feb 13, 2024

@mbostock I put up a PR to handle a few more cases but wanted to avoid larger changes. If you start working on it, I'd be happy to pair

@cinxmo cinxmo assigned mythmon and unassigned cinxmo Feb 13, 2024
@mbostock
Copy link
Member

Fixed in #768 @mythmon?

@mythmon
Copy link
Member

mythmon commented Feb 13, 2024

Yes, that gets us to a good place for launch. I think we'll still need to catch individual places where we could have improved error handling, but we can handle that in individual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

6 participants