-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CLI command error handling #482
Comments
related: #523 |
@mythmon - are you doing any of this work as part of the deploy+clack re-tooling you're doing? Or should I revisit this issue once your changes are in place? |
Let's re-evaluate this after my changes are in place. |
We can have a series of pre-deploy checks on top of error handling. I can think of:
|
Regarding file size limits: we still have a hard limit of 50MB, because after that our HTTP server closes the connection. I don't think it is a high priority to raise that limit, because as Ambassador Yuri said recently regarding that limit: if you're putting files bigger than 50MB in a project, you're making a bad user experience and should think twice about it. |
michael's #725 adds some plumbing to improve this in general, and resolves the TOO_MANY_PROJECTS case |
@mbostock I put up a PR to handle a few more cases but wanted to avoid larger changes. If you start working on it, I'd be happy to pair |
Yes, that gets us to a good place for launch. I think we'll still need to catch individual places where we could have improved error handling, but we can handle that in individual issues. |
EA bug bash: https://observablehq.com/@observablehq/ea-bug-bash
We need dramatically better error handling around CLI deploy errors. At a minimum, we should be catching all unexpected http status errors and showing a more readable/actionable error message to users. (and no stacktraces :P)
See https://oclif.io/.
The text was updated successfully, but these errors were encountered: