[exporter/chronicleexporter]: Optimize getRawField when field is "body" #1967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
getRawField is called three times for every log record. One of the calls is for reading the "field to send" value. Generally, "field to send" will be
body
. Body can be either a string or a map.If
field
is body, we can read the underlying string or map and return it. No need to use an expensive OTTL expression.Before
After
Benchmarks for string body and map body have almost no costs now.
The tests introduced in #1966 should prove that the output is the same.
Checklist