-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch to zoom #5
Comments
Hi, yeah it's on my todo. Thinking of maybe writing a carousel to go with it too. Just need some time to do it ;-) |
Awesome news then! Could you ping me when it's up? Cheers |
Would be great to have this too |
+1 |
4 similar comments
👍 |
+1 |
+1 |
+1 |
I'm feeling the pressure haha. I've implemented this in the navigator-refactor branch. See #8 (comment) for more info. |
Hi @oblador, I'm getting this to work fine on iOS but not on Android. When I click to zoom, it zooms in but doesn't pinch to zoom. It also scrolls but doesn't drag left to right to see details cut off from initial zoom. I'm using your navigator example and also cloned the navigator-refactor branch during npm install. Any help is appreciated. Thanks! |
@kwokster10: I'm aware of that issue, that's because ScrollView on android doesn't support zooming. I'm not sure if I should implement zooming for android completely custom or just wait for support to land in React Native core. |
Oh, interesting. Is there a workaround for this? Would using ViewPagerAndroid make a difference? Thanks! |
@kwokster10: ViewPagerAndroid might help with paging the images but I don't think it'll help with zooming. Should be able to do zooming with scale transforms, but it wouldn't be as fluid as native zooming nor give you higher detail when zooming. |
Hello, i couldn't get to work the version from the navigator refactor branch.. I get the following error:
The main branch works without problems for me. I'm on react-native 0.25.1 |
For those who can't get the navigator-refactor working for some reason but would like pinch-to-zoom, <LightBox
key={i}
swipeToDismiss={false}
>
<ScrollView
minimumZoomScale={1}
maximumZoomScale={2}
centerContent={true}
>
<Image
style={styles.image}
source={{'uri' : source}}
>
</Image>
</ScrollView>
</LightBox> I realize this is not ideal, but it's a quick and easy fix for a small feature |
+1 .. waiting eagerly :) |
+1 mee too... On the navigator refactor branch I am getting the same error as @pvlvsk |
@oblador: just curious about timing, are you still working on this? |
@braco: Not actively currently but I will soon need this functionality for a project I'm working on, but with |
@oblador: thanks for the clarification. Sounds like there's a bunch of hungry puppies waiting for you here, myself included! |
@oblador any update on this feature? |
Thanks @oblador! Awesome Work :) |
Would someone using the pinch to zoom feature on the navigator-refactor branch be willing to help me with this? http://stackoverflow.com/questions/40264486/including-a-library-from-a-github-branch-in-react-native?noredirect=1#comment67789465_40264486 Not sure what I'm doing wrong. Thanks in advance. update: @kobePer 's suggestion worked for me. gracias. |
@oblador for zoom, consider looking at this library https://github.com/alwx/react-native-photo-view. |
Is there a stable version of the pinch to zoom now? |
+1 ... really need / love to have this feature :) |
+1 ! |
+1 |
2 similar comments
+1 |
+1 |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
@kobePer , Hey Kobeper, the above-mentioned code was working completely in ios but in android zooming is not working, can you suggest any update on top of it? Thank you!. |
+1 |
2 similar comments
+1 |
+1 |
the above-mentioned code is working fine on IOS devices but not on Android devices! |
+1 |
2 similar comments
+1 |
+1 |
+1, would be great to have this |
+1 |
Any updates? |
@kobePer Your solution will only work for IOS any work around for android ? |
+1 |
any update ? |
Any update ? |
+1 |
Very nice update using the animated library! It really is smoother and lighter!
Do you think it would be possible - just like facebook lightbox - to enable a pinch to zoom?
Have a great day
The text was updated successfully, but these errors were encountered: