Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout of fatal error is broken #1710

Closed
lukaw3d opened this issue Oct 11, 2023 · 1 comment
Closed

Layout of fatal error is broken #1710

lukaw3d opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working ui User interface related issues

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Oct 11, 2023

http://localhost:3000/e2e click Trigger fatal saga error
localhost_3000_e2e

From quick check it may have broke in #1666

Check if it affects any other components too
@lukaw3d lukaw3d added bug Something isn't working ui User interface related issues labels Oct 11, 2023
@buberdds
Copy link
Contributor

buberdds commented Oct 12, 2023 •
edited
Loading

yes, switching from div to Grommet Box is causing this issue. Box has overlap issue (mix of flex + min-height and/or wrong/missing flex-shrink) or sth with fill prop. Will look at it.

https://github.com/oasisprotocol/oasis-wallet-web/pull/1666/commits/951726c6c9ab91c4f8b05146694209f8ab64a270#diff-e52b12bba68e0702881d99f49daf57d5de8ab70c45c6dddcf5e32fb310da95e1R39

@buberdds buberdds mentioned this issue Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui User interface related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buberdds @lukaw3d