Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of delegations to non-validators #2031

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Aug 6, 2024

Fixes #2030

https://wallet.dev.oasis.io/account/oasis1qprtzrg97jk0wxnqkhxwyzy5qys47r7alvfl3fcg/stake/active-delegations

Before After
image image

@lukaw3d lukaw3d requested a review from lubej August 6, 2024 23:32
Copy link

github-actions bot commented Aug 6, 2024

Deployed to Cloudflare Pages

Latest commit: 6955622633dd402b1490e7c23d1f366a604b5724
Status:✅ Deploy successful!
Preview URL: https://3ba365ca.oasis-wallet.pages.dev

@lukaw3d lukaw3d force-pushed the lw/fix-delegations branch from aca8635 to a8c2d1d Compare August 7, 2024 18:28
@lukaw3d lukaw3d force-pushed the lw/fix-delegations branch from a8c2d1d to e28687d Compare August 9, 2024 01:23
@@ -592,7 +592,7 @@ exports[`<ActiveDelegationList /> should match snapshot 1`] = `
class="c0"
style="display: inline-flex; white-space: nowrap; font-family: "Roboto mono", monospace; letter-spacing: 0;"
>
0.0000001
0.00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not longer an accurate value maybe it's worth adding it to expanded details as it is different value than "Total escrow"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it is missing in debonding page; delegation had it under the input field. Added as text now too:
image

@lukaw3d lukaw3d merged commit 4d65111 into master Aug 13, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/fix-delegations branch August 13, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegations view on some accounts is broken
2 participants