Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor layerOverlayMinHeight to avoid needless scrollbars #1806

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 16, 2023

Fixes #1776

Before After
My-Accounts-tab-should-get-a-private-key-1-chromium-linux My-Accounts-tab-should-get-a-private-key-1-chromium-linux
My-Accounts-tab-should-get-a-private-key-2-chromium-linux My-Accounts-tab-should-get-a-private-key-2-chromium-linux
My-Accounts-tab-should-get-a-private-key-3-chromium-linux My-Accounts-tab-should-get-a-private-key-3-chromium-linux

@lukaw3d lukaw3d requested a review from buberdds December 16, 2023 04:33
Copy link

github-actions bot commented Dec 16, 2023

Deployed to Cloudflare Pages

Latest commit: 6e67efd6b9dce3746e5dba2cf4e3061b0095057e
Status:✅ Deploy successful!
Preview URL: https://76a0c4d4.oasis-wallet.pages.dev

@lukaw3d lukaw3d force-pushed the lw/vertical-scrolls branch from 46bdd07 to 6e67efd Compare December 16, 2023 04:43
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #1806 (6e67efd) into master (0527188) will increase coverage by 0.10%.
The diff coverage is 37.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
+ Coverage   81.36%   81.47%   +0.10%     
==========================================
  Files         191      191              
  Lines        5071     5046      -25     
  Branches      931      924       -7     
==========================================
- Hits         4126     4111      -15     
+ Misses        945      935      -10     
Flag Coverage Δ
cypress 46.05% <12.50%> (+0.16%) ⬆️
jest 77.34% <37.93%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/ResponsiveLayer/index.tsx 100.00% <ø> (ø)
...omponents/Toolbar/Features/Contacts/AddContact.tsx 72.22% <ø> (-6.04%) ⬇️
...nents/Toolbar/Features/Contacts/ContactAccount.tsx 64.28% <100.00%> (-1.34%) ⬇️
...app/components/Toolbar/Features/Contacts/index.tsx 91.17% <100.00%> (-0.72%) ⬇️
...mponents/Toolbar/Features/LayerContainer/index.tsx 100.00% <100.00%> (ø)
.../app/components/Toolbar/Features/Profile/index.tsx 100.00% <ø> (ø)
...ents/Toolbar/Features/ProfileModalButton/index.tsx 96.55% <100.00%> (ø)
...app/components/Toolbar/Features/Settings/index.tsx 80.00% <ø> (+10.00%) ⬆️
src/app/components/Toolbar/Features/layer.ts 100.00% <100.00%> (ø)
src/styles/theme/ThemeProvider.tsx 96.66% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

style={{
width: '100%',
maxWidth: isMobile ? 'none' : '700px',
minHeight: `min(${layerOverlayMinHeight}, 90dvh)`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@lukaw3d lukaw3d merged commit 3873f3a into master Dec 18, 2023
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/vertical-scrolls branch December 18, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings appears scrollable for no reason
2 participants