Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable google translate on mnemonic #205

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Disable google translate on mnemonic #205

merged 1 commit into from
Jan 4, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 3, 2022

Fixes #169

@lukaw3d lukaw3d requested a review from pro-wh January 3, 2022 20:50
@lukaw3d lukaw3d force-pushed the lw/disable-translate branch 2 times, most recently from 1ac5eac to 81a0ddb Compare January 4, 2022 00:17
pro-wh
pro-wh approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you reopen this part of #169 if we still want it:

Force users to type out whole mnemonic before creating a new wallet (instead of clicking translated missing words)

@lukaw3d lukaw3d force-pushed the lw/disable-translate branch from 81a0ddb to fe840da Compare January 4, 2022 16:41
@lukaw3d lukaw3d merged commit a10d1f3 into master Jan 4, 2022
@lukaw3d lukaw3d deleted the lw/disable-translate branch January 4, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-wh pro-wh pro-wh approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@tjanez tjanez Awaiting requested review from tjanez tjanez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow user to write down wrong mnemonic (force them to type it, and disable Google Translate)
2 participants
@lukaw3d @pro-wh