-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-sdk/src/modules/core: add "core.KeyManagerPublicKey" call #1996
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
665ad13
to
64c77d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
- Coverage 59.20% 59.10% -0.10%
==========================================
Files 129 129
Lines 9592 9611 +19
==========================================
+ Hits 5679 5681 +2
- Misses 3913 3930 +17 ☔ View full report in Codecov by Sentry. |
168b68e
to
2e959ec
Compare
So, ran into some problems.
|
Relies on oasisprotocol/oasis-core#5865 being merged into oasis-core, so we can use it in new oasis-sdk. |
This is now available in the main branch that uses Oasis Core 24.3. The key manager trait now provides |
2e959ec
to
3d06649
Compare
c61bd75
to
1061a46
Compare
1061a46
to
50658ab
Compare
Re: oasisprotocol/sapphire-paratime#366
Adds
core.KeyManagerPublicKey
which returns the runtime signing public key.This key signs the ephemeral keys, one of which is the per-epoch call data public key, used for encrypting transaction data.
I have modified
core.CallDataPublicKey
to return both the Runtime ID and the Key Pair ID, both of these are necessary information to validate the signature. The remaining information (such as the checksum, expiration & epoch) are already returned bycore.CallDataPublicKey
TODO
core.CallDataPublicKey
core.KeyManagerPublicKey
Result is the 32 byte runtime signing public key.