Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil pointer dereference in GetStatus #196

Closed
kostko opened this issue Apr 29, 2021 · 0 comments · Fixed by #197
Closed

Nil pointer dereference in GetStatus #196

kostko opened this issue Apr 29, 2021 · 0 comments · Fixed by #197
Assignees
@kostko
Labels
bug Something isn't working

Comments

@kostko
Copy link
Member

kostko commented Apr 29, 2021

The GetStatus method implementation checks if the upstream service returned an error. It seems that the check is inverted so it only tries to access the response when an error occurred (in which case the response is nil).
@kostko kostko added the bug Something isn't working label Apr 29, 2021
@kostko kostko self-assigned this Apr 30, 2021
@kostko kostko mentioned this issue Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix possible nil pointer dereference in GetStatus oasisprotocol/oasis-rosetta-gateway
1 participant
@kostko