Add version info to common package and -version flag to CLI #128
Conversation
tjanez
requested review from
abukosek,
kostko and
peterjgilbert
as code owners
|
|
||
| // RosettaAPIVersion represents the Rosetta API version with which the | ||
| // Oasis Core Rosetta Gateway is guaranteed to be compatible with. | ||
| RosettaAPIVersion = "1.4.1" |
There was a problem hiding this comment.
This shouldn't be hard-coded in the future, see #129.
There was a problem hiding this comment.
You should also make https://github.com/oasisprotocol/oasis-core-rosetta-gateway/blob/master/services/network.go#L135 use the RosettaAPIVersion specified here :)
There was a problem hiding this comment.
You should also make https://github.com/oasisprotocol/oasis-core-rosetta-gateway/blob/master/services/network.go#L135 use the RosettaAPIVersion specified here :)
Good catch, fixed.
There was a problem hiding this comment.
Cool! Maybe it would be a good idea to also include the Oasis Core version? Well it would actually make more sense to include the client protocol version once oasisprotocol/oasis-core#1861 is done.
services: Use Rosetta API version defined in common package.
This should keep the number of statements in the main() function <50.
tjanez
force-pushed
the
tjanez/add-version-info
branch
from
2b84c45 to
f3cbbbe
Compare
Agreed with adding the client protocol version once that is implemented in Oasis Core. I tried adding the Oasis Core version by obtaining its value from the |
Implemented in #134.
Filled #135. |
No description provided.