Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return CORS headers also on timeout #849

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Return CORS headers also on timeout #849

merged 1 commit into from
Dec 23, 2024

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Dec 20, 2024 •
edited
Loading

Fixes: #743

PlacedCorsMiddleware outside of TimeoutHandler to ensure CORS headers are included in responses even when requests time out.

@ptrus ptrus force-pushed the ptrus/feature/cors-timeout branch from cd23799 to 0cc0bd2 Compare December 20, 2024 10:55
@ptrus ptrus mentioned this pull request Dec 20, 2024
Closed
@ptrus ptrus changed the title return CORS headers also on timeout Return CORS headers also on timeout Dec 20, 2024
@ptrus ptrus merged commit ec5641c into main Dec 23, 2024
16 checks passed
@ptrus ptrus deleted the ptrus/feature/cors-timeout branch December 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew7234 Andrew7234 Awaiting requested review from Andrew7234 Andrew7234 is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@jberci jberci Awaiting requested review from jberci jberci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare timeout errors don't return CORS headers
1 participant
@ptrus