api/consensus: support filtering blocks by proposer #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/proposed-blocks
branch
2 times, most recently
from
d6b4b43 to
6ec6874
Compare
Andrew7234
reviewed
Oct 8, 2024
ptrus
force-pushed
the
ptrus/feature/proposed-blocks
branch
from
6ec6874 to
067335a
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/proposed-blocks
branch
2 times, most recently
from
6cd96aa to
105285a
Compare
|
Hm the E2E test discovered that storing block signers does not currently work correctly when fast-syncing over the consensus blocks, detailed comment here: https://github.com/oasisprotocol/nexus/pull/646/files#r1795395104 |
ptrus
force-pushed
the
ptrus/feature/proposed-blocks
branch
from
105285a to
f1471c2
Compare
ptrus
force-pushed
the
ptrus/feature/proposed-blocks
branch
from
f1471c2 to
bb6da14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a related request for new api endpoints for signed/proposed blocks for a given validator
Design is here: https://www.figma.com/design/8dwSyYOOm3vlgbvxPGT29p/Block-Explorer-(Post-Launch)?node-id=8694-95348&node-type=frame&t=SLj8iOo49jAnc7nE-0